fix!: lightdom shim styles should be in their own files, and not required. #2665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… colors (#2566) * fix(health-index): use status tokens for colors * refactor(health-index): unshorten variable names “Programs must be written for people to read, and only incidentally for machines to execute.” * chore(health-index): add changeset * refactor(health-index): use t-shirt sizes for lg/large variable
* fix(pagination): update dark scheme disabled button background color * chore(pagination): add changeset
* feat(back-to-top): add dark color scheme support * chore(back-to-top): add changeset * fix(back-to-top): move custom element inside context demo element, nix outdated CSS * refactor(back-to-top): condense border CSS * docs(back-to-top): update style page * docs(back-to-top): update Guidelines page * docs(back-to-top): update Accessibility page
* feat(avatar): add bordered variant * docs(avatar): fix description for `layout` prop * docs(avatar): document `part` attributes on the Code page * fix(avatar): remove empty string from `variant` prop * chore(avatar): add changeset * chore(avatar): update changeset to minor, tweak content * docs(avatar): update Style docs * docs(avatar): update Guidelines page * docs(avatar): update related items / components * docs(avatar): style anatomy correction
* fix(pagination): add `--rh-color-icon-status-disabled` token * chore(pagination): add changeset * fix(pagination): make open variant stepper background transparent * fix(pagination): update rh-color-icon-status-disabled light scheme color
…2593) * fix(tabs): update dark box variant inactive tab background color * chore(tabs): add changeset * fix(tabs): implement `--rh-color-icon-status-disabled` token * fix(tabs): update rh-color-icon-status-disabled light scheme value
) * fix(button): add dark scheme support for primary variant * fix(button): update background color of danger primary variant * fix(button): update danger secondary color and border colors * fix(button): icon links only appear on the left * fix(button): update close button color tokens * fix(button): add disabled status tokens to disabled button variant * fix(button): update play icon color on dark color schemes * chore(button): add changeset * fix(button): update tokens for `color-status-disabled` and `color-text-status-disabled`
* feat(audio-player): convert media queries to container queries * chore(audio-player): add changeset --------- Co-authored-by: Steven Spriggs <[email protected]>
* fix(accordion): fix axe error regarding `aria-level` * chore(accordion): add changeset * fix(accordion): check if `ariaLevel` is not yet set in the internalsController
* feat(site-status): update light scheme background colors * fix(site-status): reduce time to go from loading to error/danger on critical status demo * chore(site-status): add changeset * docs(site-status): overview content updates * docs(site-status): content updates to the Style page * docs(site-status): update content on the Guidelines page * docs(site-status): update content and imagery on Accessibility page --------- Co-authored-by: Steven Spriggs <[email protected]>
* feat(disclosure): add open variant * feat(disclosure): add compact variant * fix(disclosure): update lightdom styles for `open` and `compact` variants * chore(disclosure): add changeset * fix(disclosure): design tweaks to the compact variant * fix(disclosure): design tweaks to the open disclosure variant * refactor(disclosure): use private vars for shared hover/focus/background colors. * refactor(disclosure): rename `variant="open"` to `variant="borderless"` * refactor(disclosure): lightdom shim `open` to `borderless` * fix(disclosure): round all the corners * chore(disclosure): changeset update about rounded borders * chore(disclosure): update variant name in changeset
* fix(card): correct layout when in parent flex box * chore(card): add changeset * docs(demos): remove duplicate `<main>` tags (#2642) * docs: fix bout typo on rh-icon guidelines (#2645) --------- Co-authored-by: Adam Johnson <[email protected]> Co-authored-by: Mark Caron <[email protected]>
#2580) * fix(jump-links): let text wrap instead of overflowing adjacent column * chore(jump-links): add changeset * chore(jump-links): changeset wording Co-authored-by: Steven Spriggs <[email protected]> --------- Co-authored-by: Steven Spriggs <[email protected]>
* fix(subnav): remove slotcontroller * chore(subnav): add changeset
…ils to load (#2560) * fix(footer): add no JS styles and vastly reduce CLS * chore(footer): add changeset * style(footer): lint CSS * fix(footer): remove fade in animation originally written to reduce CLS * fix(footer): increase gap for no JS links * fix(footer): side padding at various breakpoints for no js / not defined * chore: patch dev server lightdom * fix(footer): improve CLS in lightdom for grid and universal * fix(footer): wrap footer universal links and add appropriate space * fix(footer): make sure footer universal is placed in last grid row >992px * fix(footer): remove min-height on footer hosts This var should be removed at the next major release. * style(footer): lint lightdom css * fix(footer): touch up styling when JS disabled but template is DSD'ed * chore(footer): remove patch related to lightdom --------- Co-authored-by: Steven Spriggs <[email protected]>
|
✅ Deploy Preview for red-hat-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Size Change: 0 B Total Size: 243 kB ℹ️ View Unchanged
|
zeroedin
changed the title
* docs: updating disclosure docs and images * docs: adding alt text, removed commented out uxdot-example, fixed accessibility page SVGs * docs: disclosure image updates * docs: couple more image updates * feat: fixing keyboard interactions image * docs(disclosure): update image for keyboard interactions --------- Co-authored-by: marionnegp <[email protected]>
* feat(cta): add CSS APIs for `text-decoration` and `text-underline-offset` * chore(cta): add changeset
* docs(cta): add desaturated CTA pattern * docs(cta): format desaturated pattern * docs(cta): update desaturated pattern styles * docs(cta): desaturated secondary CTAs have their own unique styling * docs(cta): update style docs imagery * docs(cta): update Guidelines docs and imagery * docs(cta): update a11y page imagery * docs(cta): restore text on Style page * docs(cta): desaturated cta for podcast theme * docs: add summary column for tokens in element pages (#2667) * docs(tokens): remove tokens search (#2641) * docs(tokens): remove tokens search * chore: add space to trigger netlify * chore: remove space to trigger netlify * perf(code-block): set content-visibility on code-blocks (#2666) * perf(code-block): set content-visibility on code-blocks * docs(code-block): perf reproduction * perf(code-block): lower pressure on main thread when loading * docs(code-block): html ent escapes * docs: workaround for njk/11ty choking on giant html partial * style: lint --------- Co-authored-by: Steven Spriggs <[email protected]> * chore: prepare release (#2669) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs(cta): Style page content tweaks * docs(cta): fix desaturated CTA image dimensions in pattern docs * docs(cta): ensure brick variant desaturated CTAs have a strong border color --------- Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]> Co-authored-by: Benny Powers <[email protected]> Co-authored-by: coreyvickery <[email protected]> Co-authored-by: Steven Spriggs <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
… f (#2675) * fix(navigation-primary): visibily hide content from cmd+f unless dropdown/hamburger is open * chore(navigation-primary): add changeset
* fix(progress-stepper): add missing css fallback values * chore(progress-stepper): add changeset --------- Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
* fix(navigation-primary): add header and use aria-labelleby instead of aria-label * chore(navigation-primary): add changeset * docs(navigation-primary): improve docs around accessible-label * docs(navigation-primary): remove color-palette attr from demos * fix(navigation-primary): update default label, styles, header position * docs(navigation-primary): update slot docs * chore: revert last commit, wrong branch
…ty (#2646) * fix(navigation-primary): hide role list elmenets when slots are empty * chore(navigation-primary): add changeset * fix(navigation-primary): add event to slot controller init * docs(navigation-primary): update slot docs * docs(navigation-primary): slot documentation comments position * fix(navigation-primary): add hidden attribute display none * fix(navigation-primary): add important to hidden
Collaborator
|
@zeroedin would you be opposed to changing |
zeroedin
changed the title
* feat: update RH Icons version to 2.0 * chore: updating changeset * chore: updating changeset
* bumped nvmrc to latest node version * fixed typo * attempting to find a version compatible with linux CI * chore: update to latest node version * chore: revert back to lower minor release, errors in validate * chore: potential race condition, ensure analyze is run on docs command * chore: attempt to set the node version directly in the toml and other enhancements * chore: revert last changes, no changes on netlify build errors --------- Co-authored-by: Steven Spriggs <[email protected]> Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
* feat: add rh-navigation-link * fix(navigation-primary): add navigation-link support * fix(navigation-secondary): add navigation-link support * fix(subnav): add navigation-link support * test(navigation-link): clean up * fix(navigation-link): add alias decorator * fix(navigation-link): disable eslint on internals doesnt need reused * test(navigation-link): stub tests * test(audio-player): skip failing audio-player tests until we can fix * docs(navigation-link): improve component documentation * docs(navigation-link): missing ! in comments * chore(navigation-primary): remove orphaned code * fix(navigation-primary): correct tabbing through hamburger items, add navigation-link * fix(navgation-primary): styles for navigation-link * test(audio-player): revert skipped tests * fix(navigation-link): reverse logic for icon * test(navigation-vertical): skip test not supported by internals * test(navigation-link): update tests * docs(navigation-link): hard link lightdom.css * test(navigation-link): clean up test * docs(navigation-link): improve icon slot usage docs * fix(subnav): gap for rh-navigation-link with icon * docs(navigation-link): use all navigation links * docs: add rh-navigation-link to SSR config * docs(navigation-link): update readme * chore(navigation-link): add changeset * chore: add changesets for primary, secondary, and subnav * chore: update changesets * docs(naviation-link): add basic when to use to overview * docs(navigation-link): incorrect icon name * test(navigation-link): chai-ally-axe ignore rules that dont pass due to element internals * fix(navigation-link): add ability to change a links background color
* fix(pagination): correct input onchange, also use type number * fix(pagination): set currentLink on connectedCallback * test(pagination): correct pagination, timing issue * docs(pagination): query params * docs(pagination): move notes to demo description in an alert * docs(pagination): initial attempt at vue demo * docs(pagination): remove old comment from vue demo * docs(pagination): remove another old comment from vue demo * docs(pagination): skip no-undef for external vue * docs(pagination): add comment to lightdom style tag in vue demo for why it exists * docs(pagination): 11ty safe vue demo * docs(pagination): remove wc comment in vue demo * docs(pagination): remove unused ref usage in vue demo * docs(pagination): improve vue demo * docs(pagination): fix output vue demo * docs(pagination): remove style tag, lightdom fixed in dev * docs(pagination): load vue from importmap * docs(pagination): add demo description for vue * docs(pagination): remove vue from devDeps, add a static cdn link in manualimportmaps * chore: ignore vue in importmap plugin for dev server * chore: reset package-lock * chore(pagination): add changeset * docs(pagination): improve implementation guidelines * docs(pagination): remove suggestion of dont change * docs(pagination): must have href --------- Co-authored-by: Mark Caron <[email protected]> Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
Merged
2 tasks
* feat(color-palettes): add demo page Fixes #2467 * fix(tile): allow all color palettes and add demo page * fix(tile): correct CSS for color-palette rules * fix(tile): correct CSS for color-palette rules * Refactor color-palette selectors using prefix attribute selector * chore(changeset): bump @rhds/elements to minor * fix(rh-tile): correct color palette demos and update changeset formatting * ci: retrigger PR checks after clean * fix(tile): allow tile to accept all six color palettes --------- Co-authored-by: Benny Powers - עם ישראל חי! <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
:not(:defined)styles in the correct stylesheet-lightdom-shim.css. Reducing overhead of-lightdom.cssfor early developed elements.Reverted subnav lightdom change as they are happening in 2683Will need to reimplement this after fix(subnav): improve accessibility with nested list when<rh-navigation-link>is slotted #2683 mergesTODO
#2623
Testing Instructions
Notes to Reviewers
My opinion: If we don't split these files, what is the purpose of any of the
-shimfiles to begin with? If we have shim files at all, they should be consistent across the elements in terms of what they and-lightdom.cssprovide, even if that means a breaking change to align them.